Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 散点图一个数据点时调整 min max #2075

Merged
merged 2 commits into from
Dec 7, 2020
Merged

feat: 散点图一个数据点时调整 min max #2075

merged 2 commits into from
Dec 7, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Dec 6, 2020 •
edited
Loading

调整前
image

调整后
image

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2020

This pull request introduces 1 alert when merging bee20b9 into 960b741 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Dec 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 405174466

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 96.648%
Files with Coverage Reduction New Missed Lines %
src/plots/scatter/adaptor.ts 3 91.41%
Totals Coverage Status
Change from base Build 398625751: 0.007%
Covered Lines: 4158
Relevant Lines: 4196
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020 •
edited
Loading

😭 Deploy PR Preview a8042a0 failed. Build logs

🤖 By surge-preview

hustcc
hustcc reviewed Dec 6, 2020
View reviewed changes
__tests__/unit/plots/scatter/data-spec.ts Outdated Show resolved Hide resolved
src/plots/scatter/adaptor.ts Outdated Show resolved Hide resolved
src/plots/scatter/adaptor.ts Outdated Show resolved Hide resolved
src/plots/scatter/adaptor.ts Outdated Show resolved Hide resolved
@hustcc
Copy link
Member

hustcc commented Dec 7, 2020 •
edited
Loading

处理前后的截图，方便这周新茗发文章~

@hustcc hustcc self-requested a review December 7, 2020 09:47
@hustcc hustcc merged commit 290fb5a into master Dec 7, 2020
@hustcc hustcc deleted the feat/scatter branch December 7, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxfu1 @coveralls @hustcc